• Post Reply Bookmark Topic Watch Topic
  • New Topic
programming forums Java Mobile Certification Databases Caching Books Engineering Micro Controllers OS Languages Paradigms IDEs Build Tools Frameworks Application Servers Open Source This Site Careers Other Pie Elite all forums
this forum made possible by our volunteer staff, including ...
Marshals:
  • Campbell Ritchie
  • Jeanne Boyarsky
  • Ron McLeod
  • Paul Clapham
  • Liutauras Vilda
Sheriffs:
  • paul wheaton
  • Rob Spoor
  • Devaka Cooray
Saloon Keepers:
  • Stephan van Hulst
  • Tim Holloway
  • Carey Brown
  • Frits Walraven
  • Tim Moores
Bartenders:
  • Mikalai Zaikin

Suggestion: Make changing config dir more user friendly

 
Ranch Hand
Posts: 17424
  • Mark post as helpful
  • send pies
    Number of slices to send:
    Optional 'thank-you' note:
  • Quote
  • Report post to moderator
Hi everybody,

I have recently attempted to rename the config directory from config to jforum-config for my web app. I noticed there is a config.dir property in the SystemGlobals.properties file. I thought that simply chaning this value would allow me to change the name of the config dir. However, changing this broke some things because of hard coded paths to the config dir and circular references (config.dir property is in a file which is in the config dir!).

I suggest making this configurable by:
1. Moving SystemGlobals.properties to the WEB-INF level. That way it can point to the config dir.
2. Rename SystemGlobals.properties to JForumGlobals.properties.
3. Removing all the hard coded refences to "config" from InstallAction, JForumCommonServlet, ConfigLoader, I18n, and BBCodeHandler.

I have made the changes locally and can email them if needed. I'd check make the changes myself but I really don't have time to learn and setup all the source control stuff.

Thanks,

Justin

BTW - JForum is an excellent tool! Thanks for all your efforts!


[originally posted on jforum.net by Anonymous]
 
Migrated From Jforum.net
Ranch Hand
Posts: 17424
  • Mark post as helpful
  • send pies
    Number of slices to send:
    Optional 'thank-you' note:
  • Quote
  • Report post to moderator
Also, making the templates directory configurable would be helpful also.

Justin
[originally posted on jforum.net by justinfalk]
 
Migrated From Jforum.net
Ranch Hand
Posts: 17424
  • Mark post as helpful
  • send pies
    Number of slices to send:
    Optional 'thank-you' note:
  • Quote
  • Report post to moderator
Hhmm.. looks reasonable. You can send the patches ( only the patches or modified files, please... Some people send me the complete jforum application where they only changed a couple of file, making my life harder ).

As this modification requires changes in many places ( documentation, code etc.. ) and some tests will be necessary to be made, I don't know exactly when I'll include it in the CVS head.

Rafael
[originally posted on jforum.net by Rafael Steil]
 
Migrated From Jforum.net
Ranch Hand
Posts: 17424
  • Mark post as helpful
  • send pies
    Number of slices to send:
    Optional 'thank-you' note:
  • Quote
  • Report post to moderator
Thanks Rafael! I'll send you the patched files tonight.

Justin
[originally posted on jforum.net by justinfalk]
 
reply
    Bookmark Topic Watch Topic
  • New Topic